Default value for optional field

Hi guys, during working on https://github.com/47degrees/github4s/pull/547 I saw that optional fields don’t have default parameter.

For example, for issue.createLabel user need to have instance of domain.Label with (name:String, color:String) but he must to create object like Label(None,name, None, None, color, None)

Current model

final case class Label(
    id: Option[Long],
    name: String,
    description: Option[String],
    url: Option[String],
    color: String,
    default: Option[Boolean]
)

proposal

final case class Label(
    id: Option[Long] = None,
    name: String,
    description: Option[String] = None,
    url: Option[String] = None,
    color: String,
    default: Option[Boolean] = None
)

So user can create label like Label(name = "String",color = "").

WDYT?

[loonydev]

We can move option to the end and it’s reduce amount of code:

final case class Label(
    name: String,
    color: String,
    id: Option[Long] = None,
    description: Option[String] = None,
    url: Option[String] = None,
    default: Option[Boolean] = None
)

So you can use it

Label("name","color")

[fedefernandez]

@loonydev I see, thanks for the explanation. Let’s go for the defaults then.