Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Child routes with path="/" can't be matched

See original GitHub issue

Issue Description

I’m looking to group a very large amount of routes under a multi-tenant context such as https://acme.com/mytenant

This url should pull tenantName = mytenant and hit the / Route.

This works fine:

        <Route
          path="/:tenantName/"
          Component={loadable(() => import('./DashboardPage'))}
        />

But this does not:

<Route path="/:tenantName">
    <Route
      path="/"
      Component={loadable(() => import('./DashboardPage'))}
    />
</Route>

Are path props overrides or are they additive?

Issue Analytics

State:
Created 4 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

taioncommented, Jan 24, 2019

okay, that’s totally a bug then. mind if i track it on this issue?

1reaction

taioncommented, Jan 24, 2019

Yes, they’re additive. The intent was that for the sake of understandability (and also not traversing the entire route tree every time), that it didn’t make a lot of sense for children to match if their parents didn’t. Note that you can have path-less routes, though, so you can write the above as something like:

<Route Component={MainComponent}>
    <Route path="/:tenantName" />
    <Route
      path="/"
      Component={loadable(() => import('./DashboardPage'))}
    />
</Route>