`dance.openMenu` doesn't work on non-editor vscode pages
See original GitHub issuehello! thanks for the great extension.
i’m really liking dance.openMenu
, i use it as a leader key with submenus and stuff. one small problem i have is that it doesn’t work on some vscode pages: the welcome page, the fallback page (when no files are open), extension description pages etc.
i was planning to use it with a when
expression that looks like this: "when": "!inputFocus || editorTextFocus && dance.mode == 'normal'"
(not sure if this would actually work properly), but it doesn’t work even without a when
expression.
{
"key": "space",
"command": "dance.openMenu",
"args": { "menu": "leader" }
},
dance.toggle
works everywhere though. from what i see, the extension registers it a bit differently but i don’t have much experience with JS/vscode extensions to produce a sane PR 😏
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
Visual Studio Code for the Web
When accessing code from remote repositories, the web editor doesn't "clone" the repo, but instead loads the code by invoking the services' APIs...
Read more >User and Workspace Settings - Visual Studio Code
To open the Settings editor, use the following VS Code menu command: On Windows/Linux - File > Preferences > Settings; On macOS -...
Read more >Visual Studio Code User Interface
A quick overview of the Visual Studio Code user interface. Learn about the editor, window management, and special UI to handle source control, ......
Read more >Managing Extensions in Visual Studio Code
Discover, add, update, disable and uninstall Visual Studio Code extensions (plug-ins) through the Extension Marketplace.
Read more >Visual Studio Code Workspace Trust security
Workspace Trust. Visual Studio Code takes security seriously and wants to help you safely browse and edit code no matter the source or...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
thanks, i’ve built it from master and it works great!
here’s an excerpt of my current config in case anyone might be interested.
Hey there! The issue is that all commands (except for
dance.toggle
) do not run if there is no active text editor. In most cases, it doesn’t make sense to run a command if there is no active editor, so all commands actually expect an editor. However it does look likeopenMenu
specifically could be useful outside of text editors. I have a solution in mind but it’s a little hacky. I’ll investigate.