HttpRequest.META is not deprecated

Python Version

3.8.10

Django Version

3.2

Package Version

1.0.0

Description

According to the documentation of HttpRequest.META, HttpRequest.META is not deprecated in any version of django, so the rule in django-upgrade which converts these calls to request.headers and removes the HTTP prefix looks like it is too strict.

[adamchainz]

I’ve improved the description in #73 to not only mention deprecations.

(and in this particular case, it looks like this is not an official best practice, it is not mentionned in django documentation)

For old features we’ve been historically reticent to deprecate them or recommend the new one, because of the churn. My hope is this tool helps reduce the cost of that churn so we can make more required changes.

I don’t think there’s a reasonable claim that request.META["HTTP_FOO"] is “better” in any way to request.headers["Foo"]. The old way is just terrible and unfriendly.

(My primary need here is to use a tool which makes the smaller amount of migrations in my codebase required to update the django version of my repo, at least as a first pass so that it is more digestable than a diff which would also add changes related to pretended best practices. These best practices changes could come as a second pass.)

I have sympathy for this approach but I don’t really want to complicate django-upgrade. pyupgrade takes a similar “all or nothing” approach, albeit with three special case flags.

I would add a flag if there was a potential bug or compelling reason to keep request.META, but I don’t see one. If you want to incrementally add the changes, you can always use git add --patch for your commit or filter hunks with a regex.

[quentinelwin]

I’ve improved the description in #73 to not only mention deprecations.

OK thanks 😃