rc1 comment.
See original GitHub issueAs per @ellisonbg testing RC1 and commenting, apologies for shortness, I’ll assume you want efficiencies and quick review for SciPy.
It looks really great ! Here are what goes through my mind as explore. Sorry if it’s all over the place.
Altair requires the following dependencies:
numpy
pandas
py.test
If this is true, it should be in setup.py install_requires
, or don’t say it.
You also requires traitlets
in setup.py
, which is an indirect dependency, I suggest removing.
I suggest making a
extras_require = dict(
'test' = [...],
'notebook' = [...]
'jupyter' = [...]
)
if you want to.
Does it needs jupyter nbextension enable vega --py --sys-prefix
as said during the installation step (a word on that might be good)
Installation when smoothly ; It works.
- I was confuse the docs in
notebooks
, I was searching fordocs/notebook
. - I’m confused by the dotted line around graph, and the fact that save freeze the graph as PNG (but I might have bad ipywidgets)
- The colors and style looks great.
- The PNGs looks blurry to me
- I registed altair.readtehdocs.io, made Brian and Jake maintainer/owner.
.encode(...)
has a strong bytes/unicode meaning to me.- Same case kwargs feel weird
timeUnit
,labelAngle
- Examples implicitely display things as they are last cells statements, I guess people might get confused.
- I still like the color.
- rename notebook with leading number,
Introduction
/index
are not the firsts.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:13 (9 by maintainers)
Top Results From Across the Web
'Comment on amt-2021-395', Anonymous Referee #1
We thank anonymous referee #1 for evaluating our manuscript and for the very useful comments, which we treat in the following item-by-item.
Read more >How to Use the BOSS RC-1 Loop Station - YouTube
boss # rc1 #loopstation 00:00 Intro 00:05 How to Put In A 9V Battery 00:35 How to Set Up the RC-1 With Your...
Read more >1.0-rc1 Release Notes
Highlights of this release are: Spam / "unspam" comment actions. Switching a theme now creates single commit only. Maintenance mode is used during...
Read more >Komento 4.0 RC1
Fixed issue with action button not rendering dropdown when comment contains a quote. Introducing Komento Free Edition. To celebrate ...
Read more >Guidelines for formatting of git commits
Preferably the variable naming and code structure clarify the mechanics, and comments should only refer to higher-level things, such as choice of algorithm, ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
question:
in this example:
would it be possible at some future point to use:
to be smart and figure back the name of the column ?
you use the
_.<attributes>
in some places as well.The more I read the more I like it.
Not all things have been fixed , I for example still have blurry PNGs.