ignoreSynchronization still has immediate side effects, needs to be executed on control flow

Protractor Version: 5.1

I have tests that navigate to a non-Angular page (OAuth login), then after login they continue on my Angular app. The outline looks like this:

// Gonna leave to 3rd party page, disable synchronization
browser.ignoreSynchronization = true;
element(by.css('.sign-in-button')).click();

// Now we're on the login page
browser.wait(ExpectedConditions.visibilityOf(element(by.id('Email'))));
element(by.id('Email')).sendKeys('jimmy');
element(by.id('next')).click();
// .. and so on
// This one redirects back to my page:
element(by.id('submit_approve_access')).click();

// Now I want to proceed with testing my app
browser.ignoreSynchronization = false;
// Run test scenario

As you can see, I am updating ignoreSynchronization twice. Problem is, part of the call is executed in control flow, but it also immediately (synchronously) updates internalIgnoreSynchronization. As a result, this whole test fails because after navigating away to OAuth provider, it’s still looking for window.angular there.

I think it can be worked around by manually putting that in control flow:

browser.controlFlow().execute(() => { browser.ignoreSynchronization = false; });

However, it seems like a bug to me. If it is intended, I would really like to understand the rationale and correct usage (docs needed?).

[konrad-garus]

Actually, that workaround still does not put things in the right order. What seems to be working for me is:

element(by.id('submit_approve_access')).click().then(() =>
    browser.ignoreSynchronization = false);

[jan-molak]

Thanks, glad you like it :-)Yes, Blocking Proxy is a really cool project, great job! I wrote a piece on it some time ago.