q: chart.js 2.8.0

Expected Behavior

all peer deps are met

Actual Behavior

chart.js 2.8 has been released yesterday, and because we were installing “chart.js@^2.7.2” as a peer dep we now get an error about unmet peer dep

historically, I see vue-chart.js went from

• ^2.7.0 in https://github.com/apertureless/vue-chartjs/commit/fcd9071f9a7fe23ab035687ef210b88d8d24de1b
• 2.7.0 in https://github.com/apertureless/vue-chartjs/pull/225
• 2.7.x in https://github.com/apertureless/vue-chartjs/commit/d104e628e25ebd0c1d6c0ea2876f30a8f253dd94

all of that happening in sep-nov 2017, but without clear indications (the peer dep changes are tangent to other fixes)

can you confirm that you have a strict requirement on 2.7, rather than ^2.7.0 ? thanks!

Environment

• vue.js version: 2.8.0
• vue-chart.js version: ^3.4.0
• npm version: 6.7.0

[apertureless]

Oh, good catch! Fixed the peerDependency version to include older versions. I generally do not consider it as a breaking change, because either in a npm env or browser env it would work / properly build, even if the peerDependency version is mismatched.

A breaking change for me, would be an external API change, that would break peoples projects if they upgrade. Or an internal change that requires strict versions of for example vue.js to work. If vue would add some new function that I utilize and vue-chartjs thus requiring at least that version.

Because then, if people only upgrade vue-chartjs it would not work.

[andreineculau]

Forgot to ask how do you address vue-chartjs semver? Because the commit is breaking. Non-breaking would be “>=2.7 <2.9”