TornadoVM silently includes (an outdated) commons-math3 that causes problems.
See original GitHub issueDescribe the bug Some of our unit tests fail when using Tornado VM options due to (surprisingly) included commons-math3 ver 3.2 that is silently added to the classpath.
How To Reproduce
Run any code needing commons-math functionality included in a newer commons-math, i.e. the latest 3.6.1: it fails for us trying to resolve org.apache.commons.math3.fitting.WeightedObservedPoints
class.
The error is misleading by implying there’s a problem with modules management while this is a normal resolving conflict.
Error occurred during initialization of boot layer
java.lang.module.FindException: Module org.apache.commons.math3 not found
Provide a test-case and instructions of how to reproduce the issue.
Expected behavior
Commons math of the project should be used, not supplied tornadovm/bin/sdk/share/java/tornado/commons-math3-3.2.jar
A clear and concise description of what you expected to happen.
While resolving
jdk.internal.loader.BuiltinClassLoader::loadClassOrNull
should either skip TornadoVM supplied version or should provide an option to put user classpath in front of the the jars supplied with the distribution, commons-math in this case.
Computing system setup (please complete the following information):
- OS: [e.g. Ubuntu 20] MacOS
- OpenCL Version 1.2
- TornadoVM develop 0.13
Additional context
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (10 by maintainers)
Top GitHub Comments
This bug is already fixed in the
develop
branch: https://github.com/beehive-lab/TornadoVM/commit/1b59371371c01d99790d9694f375d93ecf47595dWe got the issue. It is now under code review. Thanks a lot for the report.