VirtualScroll should honor row keys

Right now, VirtualScroll uses Grid which generates its own element keys. While this works nice in most cases, having surrogate keys creates a mess once you start shifting the entries (e.g., by inserting to the top of the list) – optimally, we would like for the components to be reconciled the same way as in React. My suggestion is to therefore use key from the element rowRenderer returns as the underlying key and use the surrogate key only if the key prop is not defined there.

[bvaughn]

I’m afraid I don’t understand this issue.

Grid assigns a row key based on the item index. That’s the only safe way I’ve thought of to do things, given that react-virtualized supports dynamic row heights and therefore may have a varying number of rows visible at any time (making a key pooling/recycling approach difficult).

As of version 8, Grid defers the assignment to the rowRenderer anyway, although it passes a suggested key.

[bvaughn]

Woo hoo! That’s great. 😁

I was getting confused 😅

You’re welcome. Thanks for the kind words.