Runtime performance: trimMargin

In the current implementation(1.0.3) queries are ran through trimMargin function on each execution, which leads to completely unnecesarry allocations and resource usage.

I understands that it’s not much, but why do it in the first place when it doesn’t provide any benefit from doing so? If someone want’s to read the query in debug, he can just copy it and run through some sqlite formatter. It’s especially bad if you’re doing many small and formatted queries.

It’s even worse on native, since kotlin collections and some operations with them are slow (compared to jvm or other native languages).

[JakeWharton]

Last night after putting the baby to bed I took a shot at implementing this intrinsic in the Kotlin compiler. I got it working for margin and indent for non-interpolated strings only. Sending a PR to the compiler later today after beefing up the tests.

On Wed, Mar 6, 2019, 4:34 PM Jake Wharton <[e-mail] wrote:

Well not doing anything definitely won’t do anything! Yep.

On Wed, Mar 6, 2019 at 4:33 PM Dkhusainov [e-mail] wrote:

I’m a realist and I don’t think this will do anything for the reasons stated above.

As for the overhead problem, I’ll just make all of my heavy queries a one-liners.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/square/sqldelight/issues/1265#issuecomment-470285573, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEbVgF97z_U8UW1Y6IrHGr8FC1Asyks5vUDQQgaJpZM4bhhDJ .

[JakeWharton]

This was merged and will ship in Kotlin 1.3.40.

On Thu, Mar 7, 2019 at 9:41 AM Jake Wharton [e-mail] wrote:

Last night after putting the baby to bed I took a shot at implementing this intrinsic in the Kotlin compiler. I got it working for margin and indent for non-interpolated strings only. Sending a PR to the compiler later today after beefing up the tests.

On Wed, Mar 6, 2019, 4:34 PM Jake Wharton <[e-mail] wrote:

Well not doing anything definitely won’t do anything! Yep.

On Wed, Mar 6, 2019 at 4:33 PM Dkhusainov [e-mail] wrote:

I’m a realist and I don’t think this will do anything for the reasons stated above.

As for the overhead problem, I’ll just make all of my heavy queries a one-liners.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/square/sqldelight/issues/1265#issuecomment-470285573, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEbVgF97z_U8UW1Y6IrHGr8FC1Asyks5vUDQQgaJpZM4bhhDJ .