Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix model shader generation when normals are missing

See original GitHub issue

processPbrMetallicRoughness always expects normals to exist, but that is not always the case. We should have a separate shader path for those models that would look similar to the constant lighting in processModelMaterialsCommon.

This will fix https://github.com/AnalyticalGraphicsInc/cesium/issues/5835.

Issue Analytics

State:
Created 6 years ago
Comments:17 (11 by maintainers)

Top GitHub Comments

1reaction

tkazikcommented, Apr 10, 2018

BabylonJS has an option to createNormals based on the mesh:

https://doc.babylonjs.com/api/classes/babylon.abstractmesh#createnormals

Might be worth looking at it and get inspiration from here:

https://github.com/BabylonJS/Babylon.js/blob/c54863cf32d8045db2fc0b56949974563db75fd7/src/Mesh/babylon.abstractMesh.ts#L1801

0reactions

cesium-conciergecommented, Apr 30, 2018

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/eXxk3Oi0hEM https://groups.google.com/forum/#!topic/cesium-dev/se_9ov5HwA8 https://groups.google.com/forum/#!topic/cesium-dev/YSNaoirGXMw

If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/5838 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏