Consistent naming for library-packages
See original GitHub issueIn the context of moving pyarrow into the arrow-cpp-feedstock, there was some discussion of naming the outputs, and I brought up the following:
Regarding the naming conventions, I think it might be worth renaming
arrow-cpp
tolibarrow
. This is in line with a lot of other feedstocks, but obviously a matter of taste. In this case, we’d have to have a compatibility output ofarrow-cpp
that depends onlibarrow
, which could be dropped after a few versions.@isuruf made me aware of this in the context of faiss. Other examples I can think of off the top of my head are blas & lapack, openblas, opencv, postgresql, gdal, plus a whole bunch more (non-exhaustive).
Of course, this recipe has some counter examples to this: aws-sdk-cpp, boost-cpp, grpc-cpp, thrift-cpp, but I think they are far in the minority and the same argument could be made for renaming those (maybe worth noting that at least the last two seem to have been started by the arrow team).
Following @isuruf’s and @xhochy’s input, I’m opening this issue here. Also note @isuruf’s comment:
@isuruf:
-cpp
was a trend that I started withboost-cpp
. That was a mistake. I’m in favour of changing it, but this is not the correct place to raise the issue.
Issue Analytics
- State:
- Created 3 years ago
- Comments:17 (16 by maintainers)
Top GitHub Comments
I would prefer that in the cases where we have a binary, we should split it up into a separate output (if we are touching the package) and really keep packages with a
lib
prefix library only packages.libprotobuf
inbuild
always confuses me even though I maintain that package for a long time. For example in the case ofthrift-cpp
, I have split up the package https://github.com/conda-forge/thrift-cpp-feedstock/blob/f5a6473f172fe475bafdec30555ffcb1dcfe9652/recipe/meta.yaml#L81 as the compiler was 90% of the package size. Here the naming transition was simpler as the initial package was calledthrift-cpp
, so the new outputs didn’t clash with the existing packages.I’m in favor of using
libexample
for the name of theexample
library package.cpp
is a particular confusing name as cpp is both a common suffix for C++ source files (foo.cpp) and the name of the C Preprocessor.