question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix MessagePack JS package peer dependency

See original GitHub issue

The @aspnet/signalr-protocol-msgpack package has a peer dependency on @aspnet/signalr. This is good, but the value is static and hasn’t been updated since 1.0.0-preview3. We should either add automation to update the peer dependency on every build, or just remove it, or maybe make it a real dependency.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:12 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
BrennanConroycommented, Jun 19, 2019

This is fixed in the preview7 build

0reactions
mikaelm12commented, Jun 26, 2019

Acceptance checklist (check one item)

  • We decided not to take this fix.
  • The fix is tests-only.
  • This is a Docs issue.
  • The fix contains product changes (check all items below).
    • Relevant XML documentation comments for new public APIs are present. - Not needed
    • Narrative docs (docs.microsoft.com) are updated. (check one item below)
      • The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
      • The change requires a change to an existing article. A closed docs PR with these changes is linked here: [PR LINK]
      • The change requires no docs changes.
    • Verification has been completed. (check one item below)
      • The change is in the shared framework and was verified against the following versions
        • SDK installer: [VERSION]
        • ASP.NET Core Runtime: [VERSION]
        • .NET Core Runtime: [VERSION]
      • The change is in an OOB NuGet/NPM/JAR package and was verified against the following version of that package: aspnet-signalr-protocol-msgpack-3.0.0-preview7.19325.7
Read more comments on GitHub >

github_iconTop Results From Across the Web

Fix issue with npm peerDependencies for particular package
My application uses a set of domain packages that have the core as a peer dependency. All domain packages looks like the following:...
Read more >
msgpack-js | Yarn - Package Manager
Fast, reliable, and secure dependency management.
Read more >
MessagePack: It's like JSON. but fast and small.
MessagePack is an efficient binary serialization format. It lets you exchange data among multiple languages like JSON. But it's faster and smaller.
Read more >
msgpack/msgpack
MessagePack for ECMA-262/JavaScript/TypeScript. Latest version: 3.0.0-beta2, last published: 5 months ago. Start using @msgpack/msgpack in ...
Read more >
pnpm add <pkg>
pnpm add <pkg>. Installs a package and any packages that it depends on. By default, any new package is installed as a production...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found