question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Build all template package versions in servicing for source-build

See original GitHub issue

Currently building release/6.01xx doesn’t produce the template packages. This is because IsPackable is set to false for preview and servicing releases as described here. This doesn’t work well for .NET source-build which needs to product the entire product for every build (e.g. previews, rtm, servicing, etc).

Would it be amenable to conditionally build all template packages during source-build (e.g. Condition=“‘$(DotNetBuildFromSource)’ == ‘true’”)?

Currently source-build treats these packages as text-only packages that are checked in/reverse engineered. This solution is not ideal as it requires manual updates, is a maintenance burden, and in general is problematic.

This issue is similar in nature to https://github.com/dotnet/aspnetcore/issues/39471.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
dsplaistedcommented, Feb 7, 2022

@MichaelSimons Yes, the previous template versions should not be needed for source build. They are not included in the binary (ZIP) distribution on Windows, and I don’t think they are included in the standalone installer either. I think the reason that they are referenced and produced in the installer repo is because the older template versions are inserted into Visual Studio together with the .NET SDK.

Basically you should be good to ignore all of the templates from previous major versions in source build.

1reaction
MichaelSimonscommented, Feb 4, 2022

Let’s take a step back and make sure all template versions are necessary for our source-build scenarios. As I look at installer logic here, it looks like the 6.0 build only requires the 6.0 templates for source-build. The other version references are needed when producing the MSI. Source build doesn’t support Windows. @dsplaisted, @marcpopMSFT - can you confirm? Can we condition out the 5.0, 3.1, 3.0, and 2.1 template reference when building source-build or more abstractly non-win/non-arm?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Build Configuration Template | TeamCity On-Premises ...
You can associate all the build configurations of the project with a default template using the General Settings page of the project ...
Read more >
Build faster with Buck2: Our open source build system
Buck2, our extensible, performant, open source build system is designed to make your build experience better.
Read more >
Build Strategy Options | OpenShift Container Platform 3.11
Source build enables you to set environment values (one per line) inside your application, by specifying them in a .s2i/environment file in the...
Read more >
Build OTA packages
The resultant .zip file contains everything needed to construct OTA packages for the tardis device. You can also build the ota_from_target_files as a...
Read more >
Creating build inputs | CI/CD | OpenShift Container Platform 4.9
A working directory is constructed and all input content is placed in the working directory. For example, the input Git repository is cloned...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found