fixMissingImports breaks when adding to empty named imports

I’m not sure exactly what happened here, but I had:

import { } from "../jsx";

And that caused this:

Error: Cannot get the next when at the end of the iterator.
-- Details --
Path: V:/ts-morph/src/structures/utils/forEachStructureChild.ts
Text: "...dDeclarationStructure, ParameteredNodeStructure, TypeElementMemberedNodeStructure } from \"../base\";\r\nimport { JsxElementStructure, JsxSelfClosingElementStructure, JsxAttributedNodeStructure }{  } from \"../jsx\";\r\nimport { VariableStatementStructure } from \"../statement\";\r\n\r\n// todo: Code generate this...\r\n\r\nexp..."
Stack: Error: Cannot get the next when at the end of the iterator.
    at AdvancedIterator.next (V:\ts-morph\node_modules\ts-morph\dist\utils\AdvancedIterator.js:33:19)
    at RangeHandler.handleNode (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\RangeHandler.js:38:78)
    at NodeHandlerHelper.handleForValues (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\NodeHandlerHelper.js:12:21)
    at RangeHandler.rangeHandlerReplace (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\RangeHandler.js:48:21)
    at RangeHandler.handleNode (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\RangeHandler.js:31:18)
    at NodeHandlerHelper.handleForValues (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\NodeHandlerHelper.js:12:21)
    at RangeHandler.rangeHandlerReplace (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\RangeHandler.js:48:21)
    at RangeHandler.handleNode (V:\ts-morph\node_modules\ts-morph\dist\manipulation\nodeHandlers\RangeHandler.js:31:18)
    at Object.doManipulation (V:\ts-morph\node_modules\ts-morph\dist\manipulation\manipulations\doManipulation.js:9:21)
    at Object.insertIntoTextRange (V:\ts-morph\node_modules\ts-morph\dist\manipulation\manipulations\insertion.js:34:22)
    at Object.doManipulation (V:\ts-morph\node_modules\ts-morph\dist\manipulation\manipulations\doManipulation.js:12:15)
    at Object.insertIntoTextRange (V:\ts-morph\node_modules\ts-morph\dist\manipulation\manipulations\insertion.js:34:22)
    at applyTextChanges (V:\ts-morph\node_modules\ts-morph\dist\compiler\ast\module\SourceFile.js:656:32)
    at SourceFile.fixMissingImports (V:\ts-morph\node_modules\ts-morph\dist\compiler\ast\module\SourceFile.js:636:13)
    at Object.createForEachStructureChild (V:\ts-morph\scripts\generation\createForEachStructureChild.ts:29:31)
    at Object.<anonymous> (V:\ts-morph\scripts\generation\main.ts:46:9)
    at Generator.next (<anonymous>)
    at V:\ts-morph\scripts\generation\main.ts:7:71
    at new Promise (<anonymous>)
    at __awaiter (V:\ts-morph\scripts\generation\main.ts:3:12)

Kind of looks like that might be a bug in the compiler though.

[jdfm]

@jdfm - ahhh, so it was just the leading comment in the file?

That seems to have been the case for me at least. It would be interesting to hear from others if this fixes their issues as well.

I think it’s acceptable that comments should not be the very first lines of a file (after calling fixMissingImports()) […] instead that those comments would be pushed down below the imports, i.e. the imports to be inserted at the start of the file.

So, in this case we’re using the comment at the top of the file as a way of noting that we’re basing our implementation on someone else’s. Maybe you’d like to give extra context about a module via a code comment. There could be other use cases where a comment at the top of the file is desirable, like, maybe for licensing purposes, or for linter disabling at the file level, which is usually done with an enriched comment. The fact is, I don’t know if it’s fair to assume that the user wouldn’t want to keep that comment at the top of the file.

[…] but I would at least not expect an error, […]

Agreed.

[LarsBauer]

I get the same error when adding JSDoc to an interface declaration and then call fixMissingImports() on source file. Without JSDoc everything is working fine.

ManipulationError: Manipulation error: Error replacing tree: The children of the old and new trees were expected to have the same count (1:92).

Any idea?