Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

support v8.x of @elastic/elasticsearch

See original GitHub issue

The TypeScript-rewrite first v8 alpha of @elastic/elasticsearch is out: https://www.npmjs.com/package/@elastic/elasticsearch/v/8.0.0-alpha.0 https://twitter.com/delvedor/status/1443495948093693955

We should ensure instrumentation still works for it.

Update: Clarification that this change did not yet add instrumentation for undici. So when the default UndiciConnection is used with @elastic/elasticsearch@8, the APM agent will create an ES span, but will not create an HTTP span and will not propagate trace-context headers.

Issue Analytics

State:
Created 2 years ago
Comments:14 (10 by maintainers)

Top GitHub Comments

1reaction

mshustovcommented, Oct 26, 2021

already in progress https://github.com/elastic/kibana/issues/116109

1reaction

trentmcommented, Oct 21, 2021

@mshustov I can start looking into it soon. We are targetting our 8.0 milestone as well, but I understand that you’ll need the agent support sooner.

at least for the legacy HttpConnection

Does this mean the non-undici http client? If so, then that helps. Adding undici support so that trace-context headers are carried through to ES is not currently on our 8.0 milestone.

When we have a PR for v8 of the ES client and it if looks like it’ll take a long while before there is a release of the agent with it, then I’ll be happy to publish a “canary” version to npm for Kibana to use.

Top Results From Across the Web

Release notes | Elasticsearch JavaScript Client [8.5] | Elastic

Support for Elasticsearch v8.2.1 edit. You can find all the API changes here. Fix ndjson APIs #1688edit. The previous release contained a bug...

@elastic/elasticsearch - npm

The minimum supported version of Node.js is v8 . The library is compatible with all Elasticsearch versions since 5.x, but you should use...

@elastic/elasticsearch-canary - npm package | Snyk

Configurable, automatic discovery of cluster nodes. Persistent, Keep-Alive connections. Load balancing across all available nodes. Child client support.

elasticsearch/elasticsearch - Packagist

0 version of elasticsearch-php contains a new implementation compared with 7.x. It supports PSR-7 for HTTP messages and PSR-18 for HTTP client ...

Elasticsearch in Go, Err: "the client noticed that the server is ...

Digging in the code I see it verifies the response by looking for header.Get("X-Elastic-Product") == "Elasticsearch" . I have no idea why it's ......