question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IE11/10 multiple argument remove and add not working due to SVG test

See original GitHub issue

Near the top of the code you check for: !("classList" in document.createElementNS(“http://www.w3.org/2000/svg","g”))

IE11 and 10 will fail that test and therefore should run the code for the polyfill. But, IE11 and 10 do provide native support but lacks SVG support and lacks multiple classname arguments for add() and remove(). (Reference: http://caniuse.com/#search=classlist)

The code within the else of that same if statement contains a polyfill to add multiple argument support to add() and remove(). There is a comment in that block of code that says “Polyfill for IE 10/11 and Firefox <26.” But IE11 does not get to that point.

Are you still maintaining this library? If you are no longer maintaining, please let me know if there is a reason you stopped other than limited time to so do. If you believe addressing this potential bug is needed but you don’t have time, let me know and I’d be happy to dig in deeper.

BTW, I took a quick look at the unit tests and it appears we may be should add testing of multiple arguments for add() and remove() as well.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:16 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
thomaswcommented, Sep 30, 2016

@beck is the worst though (for reasons unrelated to this conversation).

0reactions
beckcommented, May 2, 2017
Read more comments on GitHub >

github_iconTop Results From Across the Web

How can I remove or replace SVG content? - Stack Overflow
I want to update the chart based on new data coming from a web service using AJAX, the problem is that each time...
Read more >
5 Gotchas You're Gonna Face Getting Inline SVG ... - CSS-Tricks
You call a meeting with your team to discuss moving over to inline SVG icons. Your boss is skeptical. He looks you in...
Read more >
<text> - SVG: Scalable Vector Graphics - MDN Web Docs
The SVG <text> element draws a graphics element consisting of text. It's possible to apply a gradient, pattern, clipping path, mask, ...
Read more >
Using Javascript with SVG - Peter Collingridge
I'm going to cover how to work with two types of SVGs: ... As mentioned it my basic SVG tutorial, it's also possible...
Read more >
SVG Viewport and viewBox (For Complete Beginners)
The viewport size is set by adding width and height attributes to the svg element ... If those last two parameters have the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found