question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

This repo now has few more maintainers (including myself).

Before making any big changes would like to:

Say Hi

hi

Make a todo list

  1. Rewrite tests and use real browsers to run them: https://github.com/eligrey/classList.js/pull/69
  2. Fix https://github.com/eligrey/classList.js/issues/48
  3. Publish a new version
  4. Close my fork https://github.com/yola/classlist-polyfill/issues/9
  5. Cleanup whitespace
  6. Minify via npm prepublish
  7. Start addressing open issues

Flesh out any preferences, paint a bikeshed

When writing JS I generally stick to airbnb-ish style.

For testing, prefer Mocha+chai (with karma running the tests) instead of QUnit.

Prefer plain old shell or JS scripts instead task managers.

Issue Analytics

  • State:open
  • Created 6 years ago
  • Comments:6

github_iconTop GitHub Comments

1reaction
euwestcommented, May 4, 2017

@stevenvachon:

another preference is for single-purpose pull requests.

I agree … about #53. IMO it does too much at once.

That’s @beck responding to:

I fixed #48 in the “Consolidated closures” commit in #53. I fixed whitespace in the “Whitespace fixes” commit in #53. I rewrote the tests in the “Improve tests” commit in #53.

He’s telling you he would like those to be separate PRs, not just separate commits. Condescension is not an appropriate response.

0reactions
stevenvachoncommented, May 4, 2017

He’s telling you he would like those to be separate PRs, not just separate commits. Condescension is not an appropriate response.

And I’m telling him and anyone else that they can go through the commits. I have little interest in redoing my PRs after all this time.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Developer Roadmaps
Community driven roadmaps, articles, guides, quizzes, tips and resources for developers to learn from, identify their career paths, know what they don't ...
Read more >
What is a roadmap? - The ultimate guide to ... - Roadmunk
A visual roadmap is a communication tool. They're created and presented to get all stakeholders, executives and your entire team aligned on one...
Read more >
Roadmap Basics - ProductPlan
A roadmap is a strategic plan that defines a goal or desired outcome and includes the major steps or milestones needed to reach...
Read more >
Roadmapping: Your starter guide - AHA.io
A roadmap is a visual representation of your strategic plans. It ties together your strategy (the "why"), the work you will need to...
Read more >
Roadmap - Wikipedia
A road map, a form of map that details roads and transport links · A plan, e.g.. Road map for peace, to resolve...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found