question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

2aacf7e broke error detection in kak-lsp

See original GitHub issue

After the recent updates I noticed kakoune was no longer detecting errors in elm files using this language server. Diagnostic warnings still work, but breaking errors are completely ignored. I tried the latest version of the plugin in vscode just to compare and it still works fine there. I ran a git bisect to figure out what exactly went wrong and it looks like 2aacf7e448fda9c597cd3ab085739b541452ee47 is where the issue was introduced. It also seems to affect formatting. I can work around that with kakoune’s built in format command but the error detection not working is a much bigger PITA.

Expected Behavior

error detect should work just like it did before the breaking change

Current Behavior

Errors are not detected at all when running diagnostics in kak-lsp. Warnings still get reported, so unused imports work just fine. But if I call a function that doesn’t exist, no error gets reported to the kakoune from the language-server like it used to before 2aacf7e448fda9c597cd3ab085739b541452ee47.

Steps to Reproduce (for bugs)

  1. set kak-lsp following the readme
  2. install a version of elm-language server before broken commit E.g 1.2.2
  3. call a function that has no definition in an elm file and watch kak-lsp report the error
  4. now install the latest version of elm-language-server and see how the error is no longer reported

Your Environment

  • Version used: anything after 2aacf7e448fda9c597cd3ab085739b541452ee47
  • Editor used: kakoune
  • Environment name and version (e.g. node.js 5.4): node v12.5.0
  • Operating System and version: NixOS master

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
bburdettecommented, Sep 5, 2019

Sorry! I meant the elm code errors are appearing correctly now in the editor. Its working again!

0reactions
razzeeecommented, Sep 5, 2019

I just released a new version on npm. So I’m closing this for now.

Read more comments on GitHub >

github_iconTop Results From Across the Web

kak-lsp/kak-lsp: Kakoune Language Server Protocol Client
Used for error messages in the diagnostics inside hover info. This defaults to Kakoune's built-in Error face. InfoDiagnosticHint. Used for ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found