`elm-analyse.json` is getting ignored

I haven’t been able to fully track down why, but settings in elm-analyse.json are getting ignored. As an example, if you have:

{
    "checks": {
        "ImportAll": false
    },
}

elm-ls still reports ImportAll warnings.

From my digging, it looks like the port that loads elm-analyse.json is getting initialized correctly: From file-loading-ports to context.

I haven’t poked the internals of elm-analyse to understand why it’s ignoring them.

[antew]

It looks like there are two bugs in how the elm-analyse.json file is handled.

1. I inadvertently introduced a timing bug in elm-analyse, if the first file change event happens in the language server before elm-analyse has loaded the configuration file it will skip the state where it is listening for the configuration and go with the default.
2. It would always try to load the configuration relative to the current working directory rather than the directory where elm.json is.

I’m still debating how to fix them, for elm-analyse.json I am leaning toward having it look up through parent directories so that you have the option of setting global configuration in ~/elm-analyse.json.

For the timing bug the fix is either going to be passing in the configuration as a flag, or ignoring the file change messages until everything has loaded, I am leaning toward the flag approach at the moment because it seems cleaner and would make it easier to add Elm Analyse settings panes and whatnot later on.

I should be able to get in a PR for it tomorrow night.

[razzeee]

This should be addressed by the PR linked above. Closing for now.