question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Timeslider breaks after 1000 revisions on HTML imported pads

See original GitHub issue

Tested on:

  • Etherpad: 1.8.14
  • Browsers: Chrome 94.0.4606.81 and Firefox 94.0.1
  • Clients: Private instance and rich.etherpad.com
  • Node: 12.18.0

Steps to reproduce:

  1. Create a new pad and fill it with some content
  2. Export the pad as HTML
  3. Create a second pad and import the HTML from the first pad
  4. Create enough changes to make more than 1000 revisions

What I expected to happen: The timeslider would work normally

What actually happened: Revisions after 1000 are working but all revisions < 1000 simply show the content of revision 1000.

Additional Information

  • Also affects pads which were edited by the /setHTML API endpoint (which we internally use for applying templates)
  • Most likely related to #5214
  • You can see the bug in action here (as long as the pad is kept alive): https://rich.etherpad.com/p/test3

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:2
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
JohnMcLearcommented, Nov 10, 2021

https://github.com/ether/etherpad-lite/blob/develop/src/tests/frontend/specs/timeslider_revisions.js – note that this only creates 100 revisions. Steps you can probably take to move things forward

  • Extend timeslider_revisions.js to do a test with much more revisions (IE 1k+) and see if it fails in testing or not.

I would hazard a guess that the failure is due to the changeset loading method which probably needs to be rewritten as it’s afaik code that hasn’t been touched in several years.

TBH though I think we really need to think about the timeslider. I hate that it’s a second rate citizen on it’s own page and I’d strongly advocate moving the time-slider into the main pad editor and while we’re at it expose more functionality for plugins such as the ability to replay the pad in real time… But these things are probably out of the scope of this bug.

0reactions
davuecommented, Jan 18, 2022

It looks like that copyPad works without any issues. Only copyPadWithoutHistory seems to be affected by this bug.

Is there another way to clear the history of a pad to have a workaround?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Slider — Matplotlib 3.6.2 documentation
In this example, sliders are used to control the frequency and amplitude of a sine wave. See Snapping Sliders to Discrete Values for...
Read more >
Can I Wear the Same Pad All Day? (for Teens) - Kids Health
Changing your pad every 3 or 4 hours (more if your period is heavy) is good hygiene and helps prevent bad odors. This...
Read more >
CA2896804A1 - Application programming interfaces for content ...
Content curation can be facilitated by an application programming interface (API) for creating an address for a block of content in a document...
Read more >
Whats New | Frank Zequeira - Academia.edu
Bugfixes (common) Bug with instrument tracks after adding new samples to the ... parameter changes are not sent to host Edison: broken audio...
Read more >
Untitled - The Swiss Bay
Digital Animation Bible, you can send your comments to me directly by email: george@avekta.com. I will do my best to incorporate your corrections....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found