Timeslider breaks after 1000 revisions on HTML imported pads
See original GitHub issueTested on:
- Etherpad: 1.8.14
- Browsers: Chrome 94.0.4606.81 and Firefox 94.0.1
- Clients: Private instance and rich.etherpad.com
- Node: 12.18.0
Steps to reproduce:
- Create a new pad and fill it with some content
- Export the pad as HTML
- Create a second pad and import the HTML from the first pad
- Create enough changes to make more than 1000 revisions
What I expected to happen: The timeslider would work normally
What actually happened: Revisions after 1000 are working but all revisions < 1000 simply show the content of revision 1000.
Additional Information
- Also affects pads which were edited by the
/setHTML
API endpoint (which we internally use for applying templates) - Most likely related to #5214
- You can see the bug in action here (as long as the pad is kept alive): https://rich.etherpad.com/p/test3
Issue Analytics
- State:
- Created 2 years ago
- Reactions:2
- Comments:6 (3 by maintainers)
Top Results From Across the Web
Slider — Matplotlib 3.6.2 documentation
In this example, sliders are used to control the frequency and amplitude of a sine wave. See Snapping Sliders to Discrete Values for...
Read more >Can I Wear the Same Pad All Day? (for Teens) - Kids Health
Changing your pad every 3 or 4 hours (more if your period is heavy) is good hygiene and helps prevent bad odors. This...
Read more >CA2896804A1 - Application programming interfaces for content ...
Content curation can be facilitated by an application programming interface (API) for creating an address for a block of content in a document...
Read more >Whats New | Frank Zequeira - Academia.edu
Bugfixes (common) Bug with instrument tracks after adding new samples to the ... parameter changes are not sent to host Edison: broken audio...
Read more >Untitled - The Swiss Bay
Digital Animation Bible, you can send your comments to me directly by email: george@avekta.com. I will do my best to incorporate your corrections....
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
https://github.com/ether/etherpad-lite/blob/develop/src/tests/frontend/specs/timeslider_revisions.js – note that this only creates 100 revisions. Steps you can probably take to move things forward
I would hazard a guess that the failure is due to the changeset loading method which probably needs to be rewritten as it’s afaik code that hasn’t been touched in several years.
TBH though I think we really need to think about the timeslider. I hate that it’s a second rate citizen on it’s own page and I’d strongly advocate moving the time-slider into the main pad editor and while we’re at it expose more functionality for plugins such as the ability to replay the pad in real time… But these things are probably out of the scope of this bug.
It looks like that
copyPad
works without any issues. OnlycopyPadWithoutHistory
seems to be affected by this bug.Is there another way to clear the history of a pad to have a workaround?