ExecutorService + Wildfly

Since 2.0.1, Failsafe supports ExecutorService. I have tried to use ManagedExecutorService (JEE -Wildfly) to use FailSafe in WildFly. The circuit break never switchs to half-open state.

    private final CircuitBreaker<Object> circuitBreakerRuntime = new CircuitBreaker<>()
            .onOpen(this::openCircuit)
            .onClose(this::closeCircuit)
            .onHalfOpen(this::halfCircuit)
            .withFailureThreshold(2)
            .withSuccessThreshold(1)
            .withDelay(Duration.ofSeconds(10));
...
    @Resource
    private ManagedExecutorService managedExecutorService;

...
Failsafe
                .with(hsmFailureService.getCircuitBreakerRuntime(), hsmFailureService.getRetryPolicyInit())
                .with(managedExecutorService)
                .onSuccess(e -> log.debug("HSM is ONLINE"))
                .onFailure(e -> log.warn("Retrying FAILED"))
                .get(hsmConfigInitializer::initProvider);

Any ideas?

[jhalterman]

Your stated reason for not allowing this was to force the programmer to be aware of order, but if the names are suggestive enough, wouldn’t that force awareness as well?

Yea, being more explicit wouldn’t be a bad thing, it would just be a bit more verbose. I would probably prefer to offer more explicit wrapping but only in one direction:

Failsafe.with(circuitBreaker)
  .wrapWith(retryPolicy)
  .wrapWith(fallback);

…since wrapping the other way is harder to reason about when considering pre and post execution behaviors in policies, and wrapping in both directions is just more to explain. In this case Failsafe.with(fallback, retryPolicy, circuitBreaker) could still be shorthand but at least we’d have an explicit alternative to compare it to.

[malys]

Reading your comments (see it)

The important thing to know is that the CircuitBreaker only transitions when an execution occurs.

It was not a problem of asynchronous call but I must generate executions to enable half-open state. (tricky 😃)

Thx for your help.