docs say vue, axios, and lodash are peer dependencies, but they are not

in package.json, we have

"dependencies": {
        "axios": "^0.18.0",
        "date-fns": "^2.0.0-alpha.25",
        "lodash": "^4.17.11",
        "validator": "^10.9.0",
        "vue": "2.5.17"
},

Should these not be peerDependencies ? There is something going on with npm and/or yarn that I don’t quite understand. I have a project using vue-mc, and in that project’s node_modules/vue-mc/ folder, there is another node_modules folder that contains vue. This strangely enough makes vue.runtime.esm get included in my project’s built files twice, once from the project itself and once from vue-mc. However if I just delete node_modules/vue-mc/node_modules things work as I’d expect.

What my build looks like in current state - note the doubling-up on vue.runtime.esm: This is 330.30 KiB parsed size.

What happens if I delete vue from vue-mc’s internal node_modules folder: 269.54 KiB parsed size.

_Excerpted from original post by @djsmedes in https://github.com/FiguredLimited/vue-mc/issues/89#issuecomment-468865217_

[djsmedes]

Apologies for not getting to this. I think there might still be problems around this area - as an example, I’m doing this in my main app -

import axios from "axios";
// ...
axios.defaults.xsrfCookieName = "csrftoken";
axios.defaults.xsrfHeaderName = "X-CSRFToken";

But if I’m running from vue-mc locally and it has its own axios install, then Model.save() & co. will use that axios instance, which doesn’t have those csrf settings, and my backend will reject it.

Anyway I will open a new issue when I have time to experiment a bit. Obviously running from a local install is not the actual success criterion for the package. Thanks for looking in on this!

[albertpratomo]

But if I’m running from vue-mc locally and it has its own axios install, then Model.save() & co. will use that axios instance, which doesn’t have those csrf settings, and my backend will reject it.

Just ran into the exact situation here ☝️ . Totally agree that at least Vue and Axios should be made peer dependencies.