Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug: Conditional rendering of field with promised validate throw error before submit

See original GitHub issue

Are you submitting a bug report or a feature request?

A bug report

What is the current behavior?

Since https://github.com/final-form/final-form/pull/369 we can’t use final-form with conditional rendering coupled with validation function that returns a promise.

The conditions are:

initial render of the form without field "buggyField"
other render with "buggyField"
"buggyField" field with a validate function that returns a promise.

We get the following errors and we can’t submit the form:

TypeError: Cannot set property 'validating' of undefined

TypeError: Cannot read property 'active' of undefined

it seems like form.fields[name] is deleted before function calls.

What is the expected behavior?

Sandbox Link

Sandbox

What’s your environment?

    "final-form": "^4.20.2",
    "react-final-form": "^6.5.2",

Other information

Issue Analytics

State:
Created 3 years ago
Reactions:25
Comments:6 (1 by maintainers)

Top GitHub Comments

10reactions

fzaninottocommented, Mar 18, 2021

I think https://github.com/final-form/final-form/pull/369 should be reverted if a fix for this bug doesn’t come quickly. It’s breaking many react-admin apps relying on react-final-form.

6reactions

gbakernetcommented, Mar 25, 2021

I think it’s worth reverting https://github.com/final-form/final-form/pull/409