Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Invalid date supplied: 2016-12-27T16:16:22.585Z

See original GitHub issue

It appears minDate is still not parsed. I see jumpDate is parsed, but then minDate appears to not be. https://github.com/chmln/flatpickr/blob/bc0e3a265db0988d58e23b79d610b1f23e03c335/src/flatpickr.js#L147

I assume the same issue will apply to maxDate. Every single date in the code needs to be parsed. There should be a central parsing location, as to not have all of these issues.

@chmln could we please add tests for setting minDate and maxDate to the values I am using? We are 5 patch versions in now and still having issues. This definitely needs to be tested.

Expected Behavior

Allow actually setting minDate and maxDate

Current Behavior

Invalid date

Possible Solution

Parse all the dates all the time, and add tests to catch dates not working in the future

Steps to Reproduce (for bugs)

Set minDate to '2016-12-24T16:16:22.585Z'

Your Environment

Version used: 2.0.5
Browser Name and version: Chrome
Operating System and version (desktop or mobile): OS X
Link to your project:

Issue Analytics

State:
Created 7 years ago
Comments:20 (16 by maintainers)

Top GitHub Comments

1reaction

rwwagner90commented, Oct 13, 2016

@chmln if you wouldn’t mind taking a look at my use case and helping to resolve this, that would be awesome! I would love to have ember-flatpickr on the latest, but I cannot until all the tests pass again.

0reactions

rwwagner90commented, Nov 5, 2016

Just kidding, I did a nombom and everything passes now. Thanks for your help addressing these issues @chmln!