memory leak, DOM nodes

https://codepen.io/wyzix33/pen/aeaMJx

Your Environment

• flatpickr version used:4.6.2

• Browser name and version: Chrome Version 76.0.3809.100 (Official Build) (64-bit)

• OS and version: Windows 10

I’m detecting a Memory leak when creating and destroying flatpickr, Please test with that pen, just press add, click the input to see the calendar and click remove to destroy it, repeat … This is what i’m getting:

Thanks

[chmln]

Hey guys,

This seems to have become an issue again recently. It’s happened before and is definitely solvable. I’ll investigate what’s causing the leak and push out a fix.

Will keep you all posted 😃

[Nicolasclearleaf]

+1 flatpickr version used:4.6.2 Chrome Version 76.0.3809.100 (Official Build) (64-bit) MacOS Mojave v10.14.6 (18G87)

I try to destroy flatpickr instance to reuse the input (last version 4.6.2) but this seem always exist in the DOM. and this create some conflicts for the init date also in the library : first initialization work fine but the next is wrong, on the second for example, init nodes is equal to

(14) [input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input, input.form-control.timepicker.flatpickr-input]

If I “console.log(self)” at the end of destroy() function, self is always with a flatpickr instance and input freshly set with a new flatpickr instance have a good value first and if click on the input, this set a default now() value.

I create my instances with this:

const config = {
  enableTime: true,
  noCalendar: true,
  dateFormat: "G:i K",
  minuteIncrement: 1,
  allowInput: true,
  defaultDate: null,
  disableMobile: false, // can be true to desactive the native picker on mobile
};
this.timePickerInst = flatpickr('.timepicker', config);

I can detroy() with this but if I reuse an input, normally flatpickr do the same in background, If I use this function in addition, in my console I destroy 2 times the instances but this seem to be nothing effective

timePickerDestroy(callback) {
  // destroy timepicker instances
  for (var i = this.timePickerInst.length - 1; i >= 0; i--) {
    this.timePickerInst[i].destroy(); // destroy the timepicker instance
    delete this.timePickerInst[i]; // no useful
  }
  callback && callback();
},