question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Core Feature] Improve health check to include DB connection

See original GitHub issue

Motivation: Why do you think this is important? The health of the service only reports that it is running. See Code The health check should contain a connection “ping” to the database as the service is useless without it.

Goal: What should the final outcome look like, ideally? The /healthcheck endpoint returns a 200 only if the connection to the database is successful.

Describe alternatives you’ve considered Leaving the status of the health check as is. This push the burden of testing/monitoring a reliable connection to the DB to the end user. That work involves creating another layer to the open source version of the container in order to add custom tooling. That work is non trivial and add to the burden of monitoring flyte components using a DB (i.e. flyteadmin).

[Optional] Propose: Link/Inline OR Additional context

A quick search reveal similar pattern: https://github.com/darlinggo/healthcheck/blob/v0.1.0/sql.go

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
evalsocketcommented, Sep 24, 2021

@veggiemonk I think we can close this now, As we discussed

0reactions
katrogancommented, Sep 24, 2021

@evalsocket @veggiemonk mind summarizing the resolution/what you discussed?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Health checks in ASP.NET Core | Microsoft Learn
Health checks can test an app's dependencies, such as databases and external service endpoints, to confirm availability and normal functioning.
Read more >
SQL Database Health Check route in ASP.NET Core
Implement SQL Database Health Check route in ASP.NET Core API or MVC C# applications. Add health check route to check SQL Database ......
Read more >
Health Checks in ASP.NET Core - Code Maze
Health Checks in ASP.NET Core allow us to determine the overall health and availability of our application infrastructure.
Read more >
How to implement health checks in ASP.Net Core - InfoWorld
Take advantage of health check middleware in ASP.Net Core to monitor the health of your application, its database connection, and more.
Read more >
ASP.NET Core Health Checks Explained - elmah.io Blog
With the new Health Checks feature in ASP.NET Core 2.2, health checks no longer require you to create new controllers like in the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found