[Core Feature] Improve health check to include DB connection
See original GitHub issueMotivation: Why do you think this is important? The health of the service only reports that it is running. See Code The health check should contain a connection “ping” to the database as the service is useless without it.
Goal: What should the final outcome look like, ideally?
The /healthcheck
endpoint returns a 200 only if the connection to the database is successful.
Describe alternatives you’ve considered Leaving the status of the health check as is. This push the burden of testing/monitoring a reliable connection to the DB to the end user. That work involves creating another layer to the open source version of the container in order to add custom tooling. That work is non trivial and add to the burden of monitoring flyte components using a DB (i.e. flyteadmin).
[Optional] Propose: Link/Inline OR Additional context
A quick search reveal similar pattern: https://github.com/darlinggo/healthcheck/blob/v0.1.0/sql.go
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (4 by maintainers)
@veggiemonk I think we can close this now, As we discussed
@evalsocket @veggiemonk mind summarizing the resolution/what you discussed?