ungit crashes with rapid file system modification

(This problem has only come up for me with Rust projects, due to the nature of the build procedure)

To reproduce easily:

• create an empty Cargo project: cargo new ungit_poc
• in a new shell, run ungit in that folder: cd ungit_poc && ungit
• in the first shell, run cargo: cargo check or cargo build

Ungit crashes with an error similar to:

Error: ENOENT: no such file or directory, watch '<project_dir>/target/debug/deps/rmetaY6KMh5'

This happens because the target directory is extremely volatile during compilation/checking, and ungit doesn’t seem to be written in such a way that handles extremely rapid filesystem mutation.

There are two ways to fix this:

1. Ensure Ungit does not attempt to watch files in .gitignore/.ignore
2. Change how FSWatcher is being used so that rapid changes won’t cause this race condition

[wmertens]

right, this seems like a bug with node-watch, where it tries to watch newly created folders but they’re already removed by the time it gets to it.

Mostl likely the bug is here https://github.com/yuanchuan/node-watch/blob/5743e51a861bfe3d372a99dd388626b324905065/lib/watch.js#L302-L317

@campbellcole would you mind opening an issue on node-watch?

[campbellcole]

@wmertens will do. Thanks for your time 😃