`dotnet restore` does not work on Linux when installed as global tool

Description

Paket version: 5.219.6 Last Paket version without this issue: 5.219.5

dotnet restore fails on Linux with the following message when paket is installed using dotnet tool install -g paket

The issue seems to be the following line in Paket.Restore.targets:

<PaketCommand Condition=" '$(PaketCommand)' == '' AND '$(_PaketExeExtension)' == '' ">dotnet "$(PaketExePath)"</PaketCommand>

Repro steps

Please provide the steps required to reproduce the problem

1. Install paket: dotnet tool install -g paket
2. Run paket install.
3. Run dotnet restore.

GitHub Repository with Travis CI setup: https://github.com/bash/paket-issue-3671

Expected behavior

No error.

Actual behavior

No executable found matching command "dotnet-paket"
/home/travis/build/bash/paket-bug/.paket/Paket.Restore.targets(139,5): error MSB3073: The command "dotnet "paket" restore" exited with code 1. [/home/travis/build/bash/paket-issue-3671/PaketBug/PaketBug.csproj]
The command "dotnet restore" exited with 1.

Known workarounds

Installing an older version of paket:

dotnet tool install -g paket --version 5.219.5

[NatElkins]

@atlemann Okay you’re right I prematurely declared victory before. I think I’ve actually got it this time, although it’s kind of horrible (but let’s be honest, anything having to do with MSBuild is horrible).

Add this target at the top:

  <Target Name="SetPaketCommand" >
    <!-- Call 'dotnet paket' and see if it returns without an error. Mute all the output. -->
    <Exec Command="dotnet paket --version" IgnoreExitCode="true" StandardOutputImportance="low" StandardErrorImportance="low" >
      <Output TaskParameter="ExitCode" PropertyName="LocalPaketToolExitCode" />
    </Exec>

    <!-- This is just a debug statement. -->
    <Message Importance="high" Text="$(PaketCommand) - paket command should be empty | $(LocalPaketToolExitCode) - code" />

    <!-- Then we go through our normal steps of setting the Paket command.
         I called it InternalPaketCommand here because apparently properties aren't available
         outside the targets they are declared in. -->
    <PropertyGroup>
      <_PaketExeExtension>$([System.IO.Path]::GetExtension("$(PaketExePath)"))</_PaketExeExtension>
      <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' AND '$(_PaketExeExtension)' == '.dll' ">dotnet "$(PaketExePath)"</InternalPaketCommand>
      <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' AND '$(_PaketExeExtension)' == '' AND $(LocalPaketToolExitCode) == 0">dotnet "$(PaketExePath)"</InternalPaketCommand>
      <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' AND '$(OS)' != 'Windows_NT' AND '$(_PaketExeExtension)' == '.exe' ">$(MonoPath) --runtime=v4.0.30319 "$(PaketExePath)"</InternalPaketCommand>
      <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' ">"$(PaketExePath)"</InternalPaketCommand>
    </PropertyGroup>

    <!-- The way to get a property to be available outside the target is to use this task. -->
    <CreateProperty Value="$(InternalPaketCommand)">
      <Output TaskParameter="Value" PropertyName="PaketCommand"/>
    </CreateProperty>

    <!-- This is just a debug statement. -->
    <Message Importance="high" Text="$(PaketCommand) - paket command | $(LocalPaketToolExitCode) - code" />
  </Target>

This target will be responsible for creating the PaketCommand property, which is used in two other targets, PaketRestore and PaketOverrideNuspec. Unfortunately it looks like you can’t have properties depend on targets/tasks, so I think this is the only way to do it.

Then to make sure PaketCommand is set before PaketRestore and PaketOverrideNuspec are called, you need to update the DependsOnTargets property for each of them. Top lines of those targets should look something like this:

PaketRestore:

<Target Name="PaketRestore" Condition="'$(PaketRestoreDisabled)' != 'True'" BeforeTargets="_GenerateDotnetCliToolReferenceSpecs;_GenerateProjectRestoreGraphPerFramework;_GenerateRestoreGraphWalkPerFramework;CollectPackageReferences" DependsOnTargets="SetPaketCommand;PaketBootstrapping">

PaketOverrideNuspec:

<Target Name="PaketOverrideNuspec" DependsOnTargets="SetPaketCommand" AfterTargets="GenerateNuspec" Condition="('$(IsPackable)' == '' Or '$(IsPackable)' == 'true') And Exists('$(PaketIntermediateOutputPath)/$(MSBuildProjectFile).references')" >

[atlemann]

I added one yesterday