Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Paket (in library and console) add reference for System.Windows.Forms / WindowsBase

See original GitHub issue

Description

paket 5.172.1

We’re having jobs every night that removes paket.lock and run paket install then fake build Most of our libs are Owin or technology/framework agnostic We also have few sample bootstrapping WebApi within Console app

Actual behavior

I’m starting to see diff like this :

  <Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6.2'">
      <ItemGroup>
        <Reference Include="System.Windows">
          <Paket>True</Paket>
        </Reference>
        <Reference Include="System.Windows.Forms">
          <Paket>True</Paket>
        </Reference>
        <Reference Include="WindowsBase">
          <Paket>True</Paket>
        </Reference>
        <Reference Include="System.Reactive">
          <HintPath>..\..\packages\System.Reactive\lib\net46\System.Reactive.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>

Expected behavior

It should not start adding GAC reference in csproj, especially WindowsBase System.Windows.Forms System.Windows

Known workarounds

Manually delete them, in EACH csproj one by one This one is trully fearsome

I would recommand Paket BLOCKING the paket install with a Yes/No question (with an opt out like --force) This prompt explain the WHY it is adding a GAC reference … especially big one like this …

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

inosikcommented, Jun 12, 2018

This is in the .nuspec file of System.Reactive 4.0.0:

    <frameworkAssemblies>
      <frameworkAssembly assemblyName="System.Windows" targetFramework=".NETFramework4.6" />
      <frameworkAssembly assemblyName="System.Windows.Forms" targetFramework=".NETFramework4.6" />
      <frameworkAssembly assemblyName="WindowsBase" targetFramework=".NETFramework4.6" />
    </frameworkAssemblies>

So Paket works as expected here. I just wonder why System.Reactive depends on some Windows-specific assemblies. Version 3.1.1 doesn’t depend on them, not even indirectly.

0reactions

tebecocommented, Jun 12, 2018

thx i missed tha, i was tired … my bad

i’ll check the lib and console using netcoreapp / netstandard because it leaks in projects.assets.json as this sln don’t use paket … closing this issue