paket why hangs

Description

Please provide a succinct description of your issue.

Repro steps

.\paket.exe why castle.core -v
Paket version 5.231.0
found: C:\Work\eXpandFramework\DevExpress.XAF\paket.dependencies
Parsing C:\Work\eXpandFramework\DevExpress.XAF\paket.dependencies

Expected behavior

graph display

Actual behavior

hangs on parsisng… Stops with no output

[forki]

PS D:\temp\XAF> .\.paket\paket.exe why castle.core
Paket version 5.234.1
Package system.buffers is defined more than once in group Main of D:\temp\XAF\paket.dependencies
NuGet castle.core - 4.4 is a direct (paket.dependencies) dependency.
It is part of following dependency chains:

-> Moq - 4.13
  -> castle.core - 4.4

Performance:
 - Runtime: 571 milliseconds
PS D:\temp\XAF> .\.paket\paket.exe why Xpand.VersionConverter
Paket version 5.234.1
Package system.buffers is defined more than once in group Main of D:\temp\XAF\paket.dependencies
NuGet Xpand.VersionConverter - 1.0.37 is a transitive dependency.
It is part of following dependency chains:

-> Xpand.XAF.Web.All - 0.0.2.1
  -> Xpand.XAF.Core.All - 0.0.2.1
    -> Xpand.XAF.Modules.AutoCommit - 1.0.18
      -> Xpand.Extensions.XAF - 0.0.8
        -> Xpand.VersionConverter - 1.0.37

-> Xpand.XAF.Win.All - 0.0.2.1
  -> Xpand.XAF.Core.All - 0.0.2.1
    -> Xpand.XAF.Modules.AutoCommit - 1.0.18
      -> Xpand.Extensions.XAF - 0.0.8
        -> Xpand.VersionConverter - 1.0.37

Performance:
 - Runtime: 574 milliseconds
PS D:\temp\XAF>

Great work @theimowski

[theimowski]

Seems the issue is due to cycles in dependencies between packages like Microsoft.NETCore.Platform, System.Runtime, Microsoft.NETCore.Targets and friends … Will investigate further

Edit: The issue was with using an immutable Set for recursive calls, replaced it with HashSet in #3722 and was able to run paket why on the given sample in 1 second