AttributeError: '_io.BufferedReader' object has no attribute 'temp'

Hello,

I try to use LocalFileSystem with Transaction context manager and I get the following error:

AttributeError: '_io.BufferedReader' object has no attribute 'temp'

An example:

from fsspec.implementations.local import LocalFileSystem

def main():
    fs = LocalFileSystem()

    with fs.transaction:
        with fs.open('test.txt', 'w') as fp:
            fp.write('hello')

        with fs.open('test.txt', 'r') as fp:
            s = fp.read()
        
        print(s)

if __name__ == '__main__':
    main()

An exception:

Traceback (most recent call last):
  File "scratches\scratch_94.py", line 18, in <module>
    main()
  File "scratches\scratch_94.py", line 14, in main
    print(s)
  File "lib\site-packages\fsspec\transaction.py", line 24, in __exit__
    self.complete(commit=exc_type is None)
  File "lib\site-packages\fsspec\transaction.py", line 37, in complete
    f.commit()
  File "lib\site-packages\fsspec\implementations\local.py", line 246, in commit
    os.replace(self.temp, self.path)
  File "lib\site-packages\fsspec\implementations\local.py", line 261, in __getattr__
    return getattr(self.f, item)
AttributeError: '_io.BufferedReader' object has no attribute 'temp'

If I only use write operations within transaction context it works but read operation leads to the exception.

[andersy005]

I’m opening a PR with your changes shortly

[andersy005]

the original code should not work: the file “temp.txt” has not been finalised, so you should not be able to read it.

Aha! That’s it… Thank you for the clarification! I hadn’t payed attention to the location of the read context manager.