[FEATURE]: avoid double negation by introducing `enabled:` for modules

Feature Request

Deprecate disabled: module option and introduce enabled.

Alternatively, encourage using enabled and still allow disabled in the cases where it makes the code more readable.

Background / Motivation

Starting out positive, both the positive and the negative case are easy to understand:

• enabled: ${environment.name != "local"} (read: enabled if environment is not local)
• enabled: ${environment.name == "local"} (read: enabled if environment is local)

While starting out negative, the negative case can be harder to read:

• disabled: ${environment.name != "local"} (read: disabled if environment is not local)

Examples with simple boolean algebra:

Easy to understand:

• enabled: ${environment.name == "kubernetes" || environment.name == "local-kubernetes"} (read: the module is enabled if the environment is kubernetes or local-kubernetes)
• enabled: ${environment.name != "kubernetes" && environment.name != "local-kubernetes"} (read: the module is enabled if the environment is not kubernetes and not local-kubernetes)
• disabled: ${environment.name == "kubernetes" || environment.name == "local-kubernetes"} (read: the module is disabled, if environment is kubernetes or local-kubernetes)

Hard to understand

• disabled: ${environment.name != "kubernetes" && environment.name != "local-kubernetes"} (read: the module is disabled, if environment is not kubernetes and is not local-kubernetes)

So, to sum it up, enabled is okay to understand in all cases, and disabled is hard to understand in case of double negation (at least for me, but also to other people).

What should the user be able to do?

use enabled: to configure wether a module is active, instead of disabled.

Why do they want to do this? What problem does it solve?

Readability

Suggested Implementation(s)

There are 2 options:

• We can have both enabled and disabled side by side
• We can deprecate disabled

How important is this feature for you/your team?

🌹 It’s a nice to have, but nice things are nice 🙂

[Orzelius]

I think most of this would be solved by just naming the complicated expression with a variable

variables:
  isKubernetes: ${environment.name == "kubernetes" || environment.name == "local-kubernetes"}
disabled: ${!var.isKuberetes}

[stefreak]

I’m okay with keeping both, good point!

@vvagaytsev @Orzelius I would just create a pull request towards 0.13 once all the tests pass? What do you think?