Inconsistent Numpy dependency version for Numba
See original GitHub issueProblem description
Currently, the requirements.txt
in PyElastica states the required version of numpy
as >=1.19.2
and numba
as ==0.51.0
. However this seems to be inconsistent with numba
release notes, which state that even the latest version of numba
i.e. 0.55.0 doesnt support numpy
latest release 1.22.1 and only has support till numpy
version 1.21. While numba
installs its own compatible numpy
during installation, an update to numpy
by the user can lead to dependency issues with numba
.
Suggested solution
An upper limit on installation version of numpy
i.e. >=1.19.2,<1.22
in requirements.txt
and other related locations (setup.py
). An additional suggestion is to update the numba
dependency to 0.55.0, since all tests pass in PyElastica, with the latest numba
version installed (on my Mac).
@armantekinalp please confirm the above, after which I can take this issue.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7
I see I agree with all of the above and if
numba
will catch up in a few weeks, then we don’t need to worry about putting an upper bound onnumpy
. I guess so we can close this issue afternumba
is bumped up as you mentioned.The
numba
version is updated in 5c31cfc0ad9e50fd2b0e05b926aa0d34644ff929 and 9bcfd0f050f3ce8fbd5995b65827397693e27544.