Fix warnings and make project consistent

Analyzing the repo I’ve noticed a few things which might be worth to fix.

• Fix over 60 warnings.
• Consolidate the Microsoft.NETCore.App package for the projects. Currently the projects using versions 2.0.0, 2.1.0, 2.2.0. - completed as part of https://github.com/GitTools/GitReleaseManager/pull/265
• Rename the folder GitReleaseManager to GitReleaseManager.Core to match the project name. - https://github.com/GitTools/GitReleaseManager/issues/269
• Move Extension classes to the Extensions folder - Issue here: https://github.com/GitTools/GitReleaseManager/issues/271
• Some unit test have the method format ThisIsATest() and others This_Is_A_Test(). - covered by https://github.com/GitTools/GitReleaseManager/issues/277
• Suppres the SA1310 warning in GlobalSuppressions.cs (in this case for const string MY_VALUE).

Make the project consistent with other GitTools projects (e.g. GitVersion)

// <copyright file="file.cs" company="GitTools Contributors">
//     Copyright (c) 2015 - Present - GitTools Contributors
// </copyright>
//-----------------------------------------------------------------------

• Remove the file header Classes in the GitVersion project don’t contain any file header. A class rename don’t change the filename in the header, which cause a warning and increases the maintenance effort.
• using definitions above the namespace - covered by this issue: https://github.com/GitTools/GitReleaseManager/issues/285 Visual Studio creates the using definitions above the namespace, so currently new definitions must always manually be placed below the namespace.
• Consistent folder naming - this is covered by this issue: https://github.com/GitTools/GitReleaseManager/issues/276 The folders in the project should be lowercase
  • Icons -> icons
  • Source -> src
• Move the file /Documentation/Legal/CREDITS.md to the root folder. - This will be handled here: https://github.com/GitTools/GitReleaseManager/issues/275 The /Documentation folder is also misleading, because it contains no docs. The project docs are in the docs folder.
• Unify the config extension - covered by https://github.com/GitTools/GitReleaseManager/issues/278 The config for the GitVersion project has the file extension .yml and the GitReleaseManager the extension .yaml. I would suggest to unify this aswell and use the .yml extension. The GRM should then checkt for both extensions.

[gep13]

@akordowski I will have to go through the list of items above in more detail. Some of them I have no issue with being undertaken, others will need some more thought.

[gep13]

@akordowski GitReleaseManager.Cli creates the full .Net Framework version of the application, with the GitReleaseManager.exe, and which is ultimately published to:

https://www.nuget.org/packages/gitreleasemanager https://chocolatey.org/packages/gitreleasemanager.portable

The GitReleaseManager.Tool creates a .net global tool version of the application, which is ultimately published to here:

https://www.nuget.org/packages/gitreleasemanager.tool