1.13.0rc2 feedback: Build from sdist on Windows fails
See original GitHub issueHello!
I have a system running on Python 2.7-32bit on Windows. Since the wheels for that kind of environment aren’t published, my system ends up pulling the sdist (.tar.gz) and attempts to build the wheel (as it used to do with versions 1.12.1 and earlier).
But, in the 1.13.0rc2 .tar.gz, in src\wrapt.egg-info\SOURCES.txt
, there’s this linux-specific entry (which is also an absolute path):
/home/runner/work/wrapt/wrapt/src/wrapt/_wrappers.c
I’m fairly sure linux-style absolute path shouldn’t be there since this is the source for any system to build 😃 .
I’m not sure what went wrong in the build step for it to go there. I know some sdists simply don’t include the .egg-info in the sdist, and I’ve also seen some sdists that do. I feel like I knew the differences and conditions at some point, but I don’t recall anymore, sorry!
I hope this will be of use to you. If you have questions or things you think I can do to help, let me know! Cheers!
Issue Analytics
- State:
- Created 2 years ago
- Comments:9 (7 by maintainers)
On my local macOS box was probably using
pip 21.2.2
at the time.Anyway, bit delayed as got side tracked on real work as usual, but wrapt 1.13.0rc3 on PyPi should hopefully fix it.
Just to let you know that I’ve tested 1.13.0rc3, and yup, the sdist seems cleaner, and builds on Windows now on my end.
Thanks!