Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

CompareLogic considers non equivalent objects as Equal

See original GitHub issue

Hello, I don’t know if I’m using CompareLogic in the wrong way, but I’m getting a weird behaviour as reproduced in TestCompare() bellow:

using System;
using KellermanSoftware.CompareNetObjects;
using NUnit.Framework;

namespace TestCompareNetObjects
{
    public class Sample
    {
        public Sample(string value)
        {
            Value = value;
        }

        public String Value { get; }


        private bool Equals(Sample other)
        {
            return string.Equals(Value, other.Value);
        }

        public override bool Equals(object obj)
        {
            if (ReferenceEquals(null, obj)) return false;
            if (ReferenceEquals(this, obj)) return true;
            if (obj.GetType() != this.GetType()) return false;
            return Equals((Sample) obj);
        }

        public override int GetHashCode()
        {
            return Value != null ? Value.GetHashCode() : 0;
        }
    }

    [TestFixture]
    public class TestCompareNetObjects
    {
        [Test]
        public void TestCompare()
        {
            var compareLogic = new CompareLogic
            {
                Config =
                {
                    ComparePrivateFields = true,
                    CompareProperties = true,
                    CompareReadOnly = true,
                    CompareFields = true,
                }
            };
            var sample1 = new Sample("A");
            var sample2 = new Sample("ABC");
            var comparisonResult = compareLogic.Compare(sample1, sample2);
            Assert.IsFalse(comparisonResult.AreEqual);//this fails (comparisonResult.AreEqual is True)
        }
    }
}