Sorting direction icon doesn't show up when useExternal is set

Using Griddle, I’m loading data externally by setting useExternal to true, and I found that it doesn’t render the sorting direction icon when header cell is clicked for sorting. The data sorting works with externalChangeSort but the icon doesn’t just show up.

I found some related code on line 80 in /modules/gridTitle.jsx.js

if (that.props.sortSettings.sortColumn == col && that.props.sortSettings.sortDirection === 'asc') {
                columnSort = that.props.sortSettings.sortAscendingClassName;

Here the sortDirection is always null when useExternal is set to true.

And inside changeSort function in /modules/griddle.jsx.js, it won’t set state of sortDirection simply returning when useExternal is set.

if (this.props.useExternal) {
    this.props.externalChangeSort(column, this.props.externalSortColumn === column ? !this.props.externalSortAscending : true);
    return;
}

Looking forward to have a quick fix on this.

[tatethurston]

Fixed 486.

[M3lkior]

Same issue here …