Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Required flag silently not honored when including a partial schema.

See original GitHub issue

This YAML:

  x: 3

Gives this result:

~$ pykwalify -d subschema-required-data.yaml -s subschema-required-schema.yaml 
 INFO - validation.valid

When validated against this schema:

schema;coordinate_value:
  type: number
  
mapping:
  point:
    mapping:
      x:
        required: true
        include: coordinate_value
      y:
        required: true
        include: coordinate_value

It looks like https://github.com/Grokzen/pykwalify/pull/85 was work on a similar scenario, but it seems like either the required flag at the include site should be ignored, or a warning/error should be issued signaling that this is not a valid schema definition.

Issue Analytics

State:
Created 5 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

Grokzencommented, Oct 17, 2018

Ye, i start to think that i need to rewrite the rule engine to sort this out, the lazy loading way that i am currently doing is causing more issues then what it is worth. I guess i have to fix the issues with infinite recursion problem some other way and then most of these kinds of issues would be sorted out itself.

0reactions

Grokzencommented, Nov 10, 2018

@mschaef-da Issue resolved inside branch feature/rebuild-include Closing this as fixed for now.