Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Crashes when the source file doesn't physically exist

See original GitHub issue

Affects: v1.8.3

When a file in the stream doesn’t exist on disk (quite a common scenario in a Gulp pipeline), gulp-header crashes because the path can’t be found.

I tracked the issue down to https://github.com/tracker1/gulp-header/commit/7feb21151e9101baa47a5ce61d3d6dbc7b975b08#diff-168726dbe96b3ce427e7fedce31bb0bcR38

I guess it should be enough to simply check for existence of the file:

if (fs.existsSync(file.path) && fs.lstatSync(file.path).isDirectory())

works for my use case.

Issue Analytics

State:
Created 7 years ago
Reactions:16
Comments:21 (2 by maintainers)

Top GitHub Comments

9reactions

mryellowcommented, Jun 21, 2016

Merge and deploy 1.8.4, no need to worry about the commit history being rebased, just fix it.

There are a large number of broken builds out there and you’re going to end up with a large number of users pinning their version at 1.8.2, meaning any critical fixes will no longer be deployed to these installs.

4reactions

don4of4commented, Jun 18, 2016

I hate to state the obvious, but this is rapidly becoming a very urgent issue. Any chance this will be patched by Monday?