Doctrine TypeProvider does not work for class fields

Hi all! In the following example the type provider fails to recognize types when calling getManager() on doctrine. A call to the manager is often necessary as there might be multiple of them.

Something to note is that on the following example all of the cases will work if one would use directly the $registry argument rather than the class field. Also the RegistryInterface is not in fact the default but rather a custom one inheriting Symfony\Bridge\Doctrine\RegistryInterface and overriding the default @doctrine service.

class SomeService
{
    /** @var RegistryInterface */
    private $registry;
    
    public function __construct(RegistryInterface $registry) {
        $this->registry = $registry;
        
        $works = $this->registry
            ->getRepository(Customer::class)
            ->find(1);

        $doesntWork = $this->registry
            ->getManager()
            ->getRepository(Customer::class)
            ->findBy(1);

        $neitherDoesThis = $this->registry
            ->getManager('main')
            ->getRepository(Customer::class)
            ->find(1);
    }
}

Additional info:

Item	Version
PHP	7.3.13
Plugin	0.20.198
PhpStorm	Build #PS-201.7846.90, built on June 3, 2020

[zhil]

Looks like I have this bug in PhpStorm 2020.2 with symfony plugin 0.21.203 I have entity Hospital, and SomeCommand.php

Sample code

        $hospitals = $this->em->getRepository(Hospital::class)->findBy(['oec_autoSchedule_enable' => true]);
        foreach ($hospitals as $hospital) {
            $hospitalDate = $hospital->getHospitalTimeDate();
        }

Hospital class is resolved, findBy method signature seems to be resolved (check gif), but $hospitals have type object[] 👍

findAll() / find($x) - doesnt work as well.

Any ideas how can I fix it without adding

/** @var $hospital Hospital */

?

[maldoinc]

It does seem to be fixed. However the strangest bug appears where nested objects are no longer able to be autocompleted even though their type is known. Probably a phpstorm issue though.

Does that happen for you @Jasonoro ?

$res = $this->getDoctrine()->getManager()->getRepository(Contact::class)->find(1);
$res->getCreatedAt()->format('d.m.Y');

In the above example the IDE is no longer able to autocomplete the DateTime methods from getCreatedAt. When type-hinting the res variable with a docblock everything works properly again.