Version 7.4.3 fails to accept all certificates

Describe the bug It seems that changes in version 7.4.3 skips accept-all truststore configured using builder.withUnsafeTrustMaterial() or builder.withTrustingAllCertificatesWithoutValidation()

This is because UnsafeX509ExtendedTrustManager has 0 accepted X509Certificate therefore it is skipped during checking in CombinableX509TrustManager

To Reproduce

SSLFactory.Builder builder = SSLFactory.builder().withDefaultTrustMaterial();
builder.withUnsafeTrustMaterial();
SSLFactory factory = builder.build();

SSLContext sslContext = factory.getSslContext();
SSLContext.setDefault(sslContext);

Expected behavior Validation of the TLS certificate should pass and connection should be established

Environmental Data:

• Java Version 11.0
• Gradle
• OS MacOS

Additional context The test passes with 7.3.0 and 7.4.2

[Hakky54]

Ah, yes now your issue makes more sense. Thank you for providing additional context. I think the library can be improved to cover this kind of use case. The benefit will be that you don’t need to care what the order of trustmaterial should be because it should resolve that for you. And next to that i would prefer it to be compatible with previous releases, so I will fix it and publish a new version of it this week.

[ivenhov]

Created here https://github.com/Hakky54/sslcontext-kickstart/pull/204 Hopefully i’ve done it right. I’m not sure if there is automatic way to link pull request with Github issue?