How does this behave with routers?

Hey there, awesome library that removes a lot of hassle, really!

I have this particular use case in which I am releasing a library which expose a Express router, so here is the following use case:

var linkedDataProvider = require("./ldp")
var express = require("express")
var app = express();
app.use('/test', ldp({patch: true}));

Now, the implementation of ldp is as following:

module.exports = function(opts) {
  var router = new express.Router();
  [...]
  router.post("/", postOrPatch);
  router.delete("/", deleteObj);
  [...]
  return router;
}

Now, if I want to include

router.ws(''/", realTime);

How can make this happen?

My ideas are the following

• I require(‘express-ws’)(router) ?
• I have express-ws outside my library, so if you need you can set extra property
• I have to have another function for creating ldp routes like ldp(route)(app)

Thanks a lot for your time

[HenningM]

Hi,

First of all: I’m flattered that you find this library useful.

I also agree that the feature described here would be a very nice addition, so I’ll have a look at it ASAP. Unfortunately it’s not entirely straightforward to implement support for routers since they don’t have any information on where they are mounted in the application. This means that we don’t know which path to give the WebSocketServer when we run router.ws('/socket', handler). The router could be mounted anywhere in the application.

I will try to come up with a (not too hacky) solution here though, and I’ll keep you updated.

[nicola]

This is awesome, thanks! @joepie91 , @HenningM