Travis builds should fail when scss-lint errors
See original GitHub issueExpected behavior: When your styles fail the scss-linter, the build should fail in Travis.
Actual behavior: When your styles fail the scss-linter, the Travis build still passes.
Steps to reproduce: Branch, add some styles that don’t pass the scss-linter, push your branch, and open a pull request to view the Travis build info.
You can paste the following style declaration into any stylesheet to produce scss-lint errors:
div#urmom > div.something.something span.wutwut + b.supdawg {
width:100%;
display:inline;
position:absolute;
color:rgba(0, 0, 0, 0.10)
}
I think if we can get the scss-lint to fail the ember build, that should produce the expected behavior in Travis, too. The whole point is to help enforce use of the linter and scaling our SCSS well.
cc @jkleinsc
Issue Analytics
- State:
- Created 8 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
travis ci build fails due to linting errors ? · Issue #1868 - GitHub
To fix the build failure due to linting errors in the local dev we may want to change all the statements that violate...
Read more >Travis-CI: Do not fail build because of linter warnings
I use Travis for continuous integration and want my build to fail if any unit test fails. However, I do not want my...
Read more >How to stop errors before they ever hit your codebase with ...
Step #11: Verify that the build passed. OK — the moment of truth! On your pull request, Travis CI should immediately get to...
Read more >Common Build Problems - Travis CI Docs
Sometimes, you'll see a build script causing an error and the message in the log will be something like Killed . This is...
Read more >Getting Started with Travis, NPM, linting and GreenKeeper
By doing so, it invokes a Travis build which is used to demonstrate if the upgraded dependency will cause any breakages.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
If we are going to move to stylelint via #443, we should address this issue there.
Closed in https://github.com/HospitalRun/hospitalrun-frontend/pull/488.