question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Travis builds should fail when scss-lint errors

See original GitHub issue

Expected behavior: When your styles fail the scss-linter, the build should fail in Travis.

Actual behavior: When your styles fail the scss-linter, the Travis build still passes.

Steps to reproduce: Branch, add some styles that don’t pass the scss-linter, push your branch, and open a pull request to view the Travis build info.

You can paste the following style declaration into any stylesheet to produce scss-lint errors:

div#urmom > div.something.something span.wutwut + b.supdawg {
  width:100%;
  display:inline; 
  position:absolute; 
  color:rgba(0, 0, 0, 0.10)
}

I think if we can get the scss-lint to fail the ember build, that should produce the expected behavior in Travis, too. The whole point is to help enforce use of the linter and scaling our SCSS well.

cc @jkleinsc

Issue Analytics

  • State:closed
  • Created 8 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
jkleinsccommented, May 13, 2016

If we are going to move to stylelint via #443, we should address this issue there.

Read more comments on GitHub >

github_iconTop Results From Across the Web

travis ci build fails due to linting errors ? · Issue #1868 - GitHub
To fix the build failure due to linting errors in the local dev we may want to change all the statements that violate...
Read more >
Travis-CI: Do not fail build because of linter warnings
I use Travis for continuous integration and want my build to fail if any unit test fails. However, I do not want my...
Read more >
How to stop errors before they ever hit your codebase with ...
Step #11: Verify that the build passed. OK — the moment of truth! On your pull request, Travis CI should immediately get to...
Read more >
Common Build Problems - Travis CI Docs
Sometimes, you'll see a build script causing an error and the message in the log will be something like Killed . This is...
Read more >
Getting Started with Travis, NPM, linting and GreenKeeper
By doing so, it invokes a Travis build which is used to demonstrate if the upgraded dependency will cause any breakages.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found