Updating patient causes duplicate due to document version conflict

🐛 Bug Report

When you update an existing document in PouchDB, you need to give the database the _rev of the document that’s currently in the database. If you supply an older _rev, it will cause a document update conflict. When we update a Patient, this creates a new _rev but we are not pulling that out of the database and updating our Redux state with it. The logic in saveOrUpdate currently falls back to a regular save when an error is thrown from db.put, so if you try to update a Patient twice it creates a duplicate document (the first update works).

To Reproduce

Create a Patient and add two Related Persons. The Patient will be duplicated.

[MatthewDorner]

I’m not totally clear on the Redux stuff yet. Maybe try to find other codebases that use PouchDB and Redux and see how they do it?

There is also a concept of “isDirty” for telling when a data model has been modified but not been saved to database yet, that probably connects with this issue somehow.

[ocBruno]

saveOrUpdate does:

await this.db.put(entityToUpdate)
return this.find(entity.id)

and then updatePatientSuccess is supposed to set that Patient to state. So that all seems like it ought to work. I’d try debugging around those functions and see what the _rev of the patient being passed around it, to see where it’s breaking.

I was mistakened thinking that the related person didn’t have to be created before adding it, maybe we could redirect to create person if the related person doesn’t exist error appear.

I am going to work on a suggestion to abstract the patient and will be back to work on this issue after seeing how that resolves so we don’t need to do any refactoring afterwards!

https://github.com/HospitalRun/hospitalrun/issues/179