Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rendering Speed

See original GitHub issue

Hi,

I’m having ton of fun using this sweet library. However, I’m just wondering if there’s any way to bring up the performance.

At the moment, the rendering speed of the component is pretty slow and the associated input components which shares the state gets affected resulting in typing lag.

Please see the code below as an example

const SelectSales = pure(
  ({ newBooking, setNewBooking, salesReps, ...props }) => {
    return (
      <View style={{ display: "flex", flexDirection: "row", zIndex: 3 }}>
        <Text
          style={{
            padding: 5,
            paddingRight: 0,
            marginLeft: 15,
            fontWeight: "500",
            fontSize: 18,
            letterSpacing: 2,
          }}
        >
          By{" "}
        </Text>

        <DropDownPicker
          showArrow={false}
          zIndex={500}
          defaultValue={newBooking.calId}
          placeholder="..."
          items={salesReps}
          style={{ borderWidth: 0, backgroundColor: "rgba(52, 52, 52, alpha)" }}
          containerStyle={{ width: 150 }}
          itemStyle={{
            justifyContent: "flex-start",
          }}
          labelStyle={{
            fontWeight: "500",
            fontSize: 18,
            letterSpacing: 2,
          }}
          onChangeItem={e => {
            setNewBooking({ ...newBooking, calId: e.value });
          }}
        />
      </View>
    );
  }
);

<Input
      placeholder="Quote for ..."
      value={newBooking.summary}
      inputStyle={{ fontWeight: 500, color: "#31546A" }}
      onChangeText={e => {
         setNewBooking({ ...newBooking, summary: e });
      }}
/>

Any suggestions, please let me know.

Thanks!

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:10 (1 by maintainers)

Top GitHub Comments

4reactions

LucasRobert123commented, Dec 10, 2020

Segue o link do drive, nele esta o arquivo que fiz as modificações https://drive.google.com/file/d/1kCj94DnWdLk0jiNfhAFg2KYfo420EDBI/view?usp=sharing

Em qui., 10 de dez. de 2020 às 14:01, Lennyk notifications@github.com escreveu:

Como faz? Eu não sei fazer pull request Em qui, 29 de out de 2020 19:13, Fabio Freitas notifications@github.com escreveu: … <#m_3348743481981832315_> Ola, eu clonei repositorio e corrigi o bug de renderização, caso o proprietario do repositorio queira que eu mande para ele upar pra todo mundo usar, so falar cmg Sobe um pull request fazendo favor. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#84 (comment) https://github.com/hossein-zare/react-native-dropdown-picker/issues/84#issuecomment-719054215>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMALDR7FH7ECVN6LLVNTTXLSNHSKFANCNFSM4P7EARFQ .

Pode mandar o link do seu clone?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hossein-zare/react-native-dropdown-picker/issues/84#issuecomment-742654219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMALDR5MO5CJO6GAUVHK6BLSUD5HPANCNFSM4P7EARFQ .

4reactions

hossein-zarecommented, Aug 14, 2020

Hello,

FlatList was the best way to boost the performance but using the package inside ScrollViews was not ideal with FlatList and the annoying warnings. However, There’s another way to handle the items with ScrollView but these days i’m very busy and can’t update the package. I’ll let you know if there’s any change.

Thanks.