Redux-saga compatibility

Hi @Hotell, thanks a lot for the library. It provides the best typesafe Redux + Typescript FSA solution (as far as I can see).

Unfortunately it does not work with Redux-saga as expected.

The problem is createAction() function returns frozen object in DEV environment, but Saga does Object.defineProperty(action, SAGA_ACTION, { value: true }) which leads to an exception:

TypeError: Cannot define property @@redux-saga/SAGA_ACTION, object is not extensible

For now I solve this problem by ‘unfreezing’ the action: yield put({...Actions.fetchSuccess(data)}).

But my question is do we really need to return frozen action object with createAction()? I understand it provides more ‘safe-to-be-used’ FSA, but on the other hand this solution conflicts with quite a popular Redux tool.

[sneas]

Thanks for your reply, @JamesAlias. I suppose Saga uses Object.defineProperty instead of Object.assign in order not to expose it’s action’s modifications to Redux Dev Tools…

I’ve also decided to switch to Redux-Observables.

Will close the issue even though I still believe redux-saga compatibility could be beneficial for the project by increasing it’s popularity.

[navneet-g]

Sure … will do 😃