Rename TokenClientExtensions.Request*Async

TokenClient has several extension methods whose names are misleading:

• RequestAuthorizationCodeAsync
• RequestRefreshTokenAsync
• RequestClientCredentialsAsync
• RequestResourceOwnerPasswordAsync
• etc

The method names seem to imply that the method “requests an authorization code” or “requests a refresh token”, which is not true. It actually requests a token using an authorization code, or a refresh token.

Since I see there’s a new major version in the works, it could be an opportunity to take the breaking change and rename those methods to something more accurate.

[thomaslevesque]

Well - naming is hard

Indeed it is. But don’t you think something like RequestTokenUsingAuthorizationCode would be less confusing? Maybe ask around you and see what people think 😉

[thomaslevesque]

Thanks @leastprivilege

TokenClient is deprecated.

If you want to review code, use the v4 branch.

What is used instead of TokenClient then? I still see it in the v4 branch. It looks like the extension methods I mentioned are now instance methods, but they still have misleading names.