Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature: Support Mobx strict mode

See original GitHub issue

Hi! When I enable strict mode via configure({ enforceActions: true });, it seems to cause mobx to throw an Error from within this library. Specifically, I think it comes from Document._onSnapshot when the transaction updates _fetching via this line:

this._fetching.set(false);

Is there anything I can do in my usage of firestorter to allow me to enforce actions and also not run into this issue? I am happy to contribute, so if you point out a place in the code that you think we could update something, let me know and I’ll submit a PR.

Cheers!

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:7 (4 by maintainers)

Top GitHub Comments

2reactions

IjzerenHeincommented, Oct 25, 2018

Not yet. I will pick this up in a couple weeks after my vacation. It’s basically the next thing on my prio list 👍

Op wo 24 okt. 2018 19:23 schreef Michael Zipperle <notifications@github.com

:

Is there already a solution to reenable enforceActions?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/IjzerenHein/firestorter/issues/22#issuecomment-432601298, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5ekXQN5AH6XF7KLJxOsrOoIwG4mO-yks5uoD-IgaJpZM4U9-mZ .

1reaction

IjzerenHeincommented, Nov 23, 2018

Hi, MobX strict mode is now supported in v1.1.0. Let me know whether this solves the problem for you. cheers