Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
No bounds checking on fill/trace buf access
See original GitHub issueI’m having some trouble processing big 3d volumes using the library. The cause seems to be a lack of bounds checking on buf access in fill() and trace(), buf being statically sized. Due to the numba.jit usage it manifests as a segfault due to the out-of-bounds write.
Here’s a PR to add that bounds checking, and allows caller specification of the fixed buffer size to build_sknw():
https://github.com/yxdragon/sknw/pull/2
I guess it could also be dynamically resized, but I’m not familiar with numba.jit flavoured python so I’ll leave that.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I found that in build_sknw(ske, multi=False, iso=True, ring=True) if ske is of type np.uint8, then if node num > 255 - 10, node_num will be 0, that is a bug
so if node num > 255, we shoud make sure ske is of type np.int64
131042 * 8(int64) = 1M 131042 *1024 * 8 = 1G